feature: validate list devices that have not been polled in the last 5 minutes or took more than 5 minutes to poll #5037

Merged
merged 5 commits into from Nov 23, 2016

Projects

None yet

4 participants

@murrant
Contributor
murrant commented Nov 21, 2016

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

@murrant murrant feature: validate list devices that have not been polled in the last …
…5 minutes or took more than 5 minutes to poll
38fd049
@laf
Member
laf commented Nov 22, 2016

I'm not sure about this as it stands, if you've got a lot of devices this is just going to spam the console.

What about limiting the output to 10-20 devices, just say how many devices aren't polled or if possible provide a link to the direct page to see which ones haven't polled.

@murrant
Contributor
murrant commented Nov 23, 2016

I could see limiting the results and saying ... and x more.

@murrant
Contributor
murrant commented Nov 23, 2016

We should do the same for the file permissions.

@laf
Member
laf commented Nov 23, 2016

I'll sort the file perms one out and push to this branch

@murrant murrant Limit the amount of items that can be printed by validate.php
d75b8dc
@murrant murrant Make print_list() a little easier to read
e405443
@murrant murrant Make print_list() a little easier to read
41c6094
@murrant murrant Remove extra lines added...
a6bd34b
@scrutinizer-notifier

The inspection completed: 1 updated code elements

@laf laf merged commit 6890a71 into librenms:master Nov 23, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@murrant murrant deleted the murrant:validate-print-devices branch Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment