Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
enable override of \$config values set in includes/definitions.inc.php #5096
My personal opinion is no to this.
This could increase support burden as users can now edit two different config files. It also means that everything in definitions is now changeable so when someone is talking about (as an example) the small overview graphs not working, we expect to see the ones in definitions but now the user could have changed them all to three other graphs. So overall this means we can no longer trust what we expect to see.
The reason this was needed was to change the device type of an OS. This is possible (per device) in the WebUI. Whilst not the perfect solution for this, it is a solution and one that doesn't come at a cost to the potential burden this could bring. We will never be everything to everyone and this strikes me as one of those areas where a specific need shouldn't be reason to merge something in.