New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: More Cisco ASA Polling Performance Improvements #5104

Merged
merged 2 commits into from Dec 12, 2016

Conversation

Projects
None yet
4 participants
@Rosiak
Contributor

Rosiak commented Dec 1, 2016

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

MIBs used in these places are not supported on the ASA, so no reason to use the code.
Saw improvement on one device that went from 25s poll time to 16s, another went from 7s to 5s aprox.

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Dec 1, 2016

Auto-Deploy finished, Test PR at http://5104.ci.librenms.org or https://5104.ci.librenms.org

@@ -1,6 +1,6 @@
<?php
if ($device['os'] != 'Snom') {
if ($device['os'] != 'Snom' && $device['os'] != 'asa') {

This comment has been minimized.

@laf

laf Dec 2, 2016

Member

Could you do:

if (starts_with($device['os'], array('Snom', 'asa'))) {

Instead?

This comment has been minimized.

@laf

laf Dec 9, 2016

Member

Sorry should have been if(! or - === false

@laf

This comment has been minimized.

Member

laf commented Dec 9, 2016

fix
@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Dec 12, 2016

Auto-Deploy finished, Test PR at http://5104.ci.librenms.org or https://5104.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Dec 12, 2016

The inspection completed: 5 new issues

@laf laf merged commit e56d263 into librenms:master Dec 12, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

VimCommando added a commit to VimCommando/librenms that referenced this pull request Jan 4, 2017

@Rosiak Rosiak deleted the Rosiak:asa-perf branch Feb 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment