refactor: More Cisco ASA Polling Performance Improvements #5104

Merged
merged 2 commits into from Dec 12, 2016

Projects

None yet

4 participants

@Rosiak
Contributor
Rosiak commented Dec 1, 2016

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

MIBs used in these places are not supported on the ASA, so no reason to use the code.
Saw improvement on one device that went from 25s poll time to 16s, another went from 7s to 5s aprox.

@Rosiak Rosiak refactor: More Cisco ASA Polling Performance Improvements
e09181e
@@ -1,6 +1,6 @@
<?php
-if ($device['os'] != 'Snom') {
+if ($device['os'] != 'Snom' && $device['os'] != 'asa') {
@laf
laf Dec 2, 2016 Member

Could you do:

if (starts_with($device['os'], array('Snom', 'asa'))) {

Instead?

@laf
laf Dec 9, 2016 Member

Sorry should have been if(! or - === false

@laf
Member
laf commented Dec 9, 2016
@Rosiak Rosiak fix
a33e0e4
@scrutinizer-notifier

The inspection completed: 5 new issues

@laf laf merged commit e56d263 into librenms:master Dec 12, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@VimCommando VimCommando added a commit to VimCommando/librenms that referenced this pull request Jan 4, 2017
@Rosiak @VimCommando Rosiak + VimCommando refactor: More Cisco ASA Polling Performance Improvements (#5104) 7edea0e
@Rosiak Rosiak deleted the Rosiak:asa-perf branch Feb 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment