Added new device Zyxel MES3528 #5120

Merged
merged 2 commits into from Dec 7, 2016

Projects

None yet

4 participants

@erotel
Contributor
erotel commented Dec 6, 2016 edited

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

root Added new device Zyxel MES3528
5d7643a
@erotel erotel changed the title from Added new device Zyxel MES3528 to newdevice:Added new device Zyxel MES3528 Dec 6, 2016
@erotel erotel changed the title from newdevice:Added new device Zyxel MES3528 to Added new device Zyxel MES3528 Dec 6, 2016
tests/snmpsim/zynos-mes.snmprec
@@ -0,0 +1,2 @@
+1.3.6.1.2.1.1.1.0|4|MES Something
@laf
laf Dec 7, 2016 Member

Is this the full output from sysDescr? We require the full output if you can please.

@erotel
erotel Dec 7, 2016 Contributor

I have copied and modified the original file zynos-es.snmprec

1.3.6.1.2.1.1.1.0|4|ES Something
1.3.6.1.2.1.1.2.0|6|1.3.6.1.4.1.890

I thought that's how I'll support all switches ZyXEL MES series.

@laf
laf Dec 7, 2016 Member

Es is because we don't have the data. If you can add the proper sysdescr output we can merge this

Martin Zatloukal Added new device Zyxel MES3528
98c2ff6
@erotel
Contributor
erotel commented Dec 7, 2016 edited

Im change files.

root@95-librenms:~# snmpbulkwalk -v2c -c public zrz3975
iso.3.6.1.2.1.1.1.0 = STRING: "MES-3528"
iso.3.6.1.2.1.1.2.0 = OID: iso.3.6.1.4.1.890.1.5.8.51
`

snmpbulkwalk from Zyxel ES-2024A

root@95-librenms:/opt/librenms/tests# snmpbulkwalk -v2c -c public blok15
iso.3.6.1.2.1.1.1.0 = STRING: "ES-2024A"
iso.3.6.1.2.1.1.2.0 = OID: iso.3.6.1.4.1.890.1.5.8.16
`

@scrutinizer-notifier

The inspection completed: No new issues

@laf laf added the New-Device label Dec 7, 2016
@laf
laf approved these changes Dec 7, 2016 View changes
@laf laf merged commit 5810c3a into librenms:master Dec 7, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@murrant murrant added a commit to murrant/librenms that referenced this pull request Dec 8, 2016
@erotel @murrant erotel + murrant newdevice: Added support for Zyxel MES3528 (#5120) 1ef2267
@erotel erotel deleted the unknown repository branch Jan 2, 2017
@VimCommando VimCommando added a commit to VimCommando/librenms that referenced this pull request Jan 4, 2017
@erotel @VimCommando erotel + VimCommando newdevice: Added support for Zyxel MES3528 (#5120) e4882f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment