New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added feature to enable os Discovery for Brocade NOS V4.X and below. #5158

Merged
merged 4 commits into from Dec 14, 2016

Conversation

Projects
None yet
4 participants
@mattschwen
Contributor

mattschwen commented Dec 12, 2016

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Dec 12, 2016

Auto-Deploy finished, Test PR at http://5158.ci.librenms.org or https://5158.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Dec 12, 2016

Auto-Deploy finished, Test PR at http://5158.ci.librenms.org or https://5158.ci.librenms.org

@@ -962,6 +962,7 @@ public function testNos()
$this->checkOS('nos');
$this->checkOS('nos', 'nos1');
$this->checkOS('nos', 'nos2');
$this->checkOS('nos', 'nos3');

This comment has been minimized.

@laf

laf Dec 12, 2016

Member

Sounds petty but this needs to be lined up :)

@@ -1,5 +1,13 @@
<?php
$fabos_objectid = array(

This comment has been minimized.

@laf

laf Dec 12, 2016

Member

Out of interest why is this called fabos?

This comment has been minimized.

@mattschwen

mattschwen Dec 13, 2016

Contributor

Good find, I modified this from my initial thought that this was FABOS when it turned out to be NOS.

@laf laf added the Device 🖥 label Dec 12, 2016

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Dec 13, 2016

Auto-Deploy finished, Test PR at http://5158.ci.librenms.org or https://5158.ci.librenms.org

@@ -0,0 +1,2 @@
1.3.6.1.2.1.1.1.0|4|Brocade-VDX-VCS 1
1.3.6.1.2.1.1.2.0|6|1.3.6.1.4.1.9.1.1588

This comment has been minimized.

@laf

laf Dec 14, 2016

Member

The php unit tests are failing because this isn't matching. You are looking for .1.3.6.1.4.1.1588.2.2.1.1 but providing 1.3.6.1.4.1.9.1.1588 so this test fails.

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Dec 14, 2016

The inspection completed: No new issues

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Dec 14, 2016

Auto-Deploy finished, Test PR at http://5158.ci.librenms.org or https://5158.ci.librenms.org

@laf laf merged commit de87fc8 into librenms:master Dec 14, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mattschwen

This comment has been minimized.

Contributor

mattschwen commented Dec 14, 2016

Thank you for having patients with me!

@mattschwen mattschwen deleted the mattschwen:brocadeNOS branch Dec 14, 2016

@laf

This comment has been minimized.

Member

laf commented Dec 14, 2016

Thanks for the work :)

VimCommando added a commit to VimCommando/librenms that referenced this pull request Jan 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment