fix for cisco hardware name detection #5167

Merged
merged 1 commit into from Dec 16, 2016

Projects

None yet

5 participants

@crcro
Contributor
crcro commented Dec 14, 2016 edited

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

fixed cisco hardware name detection (always returning value from SNMPv2-MIB:CISCO-PRODUCTS-MIB, which is ugly formatted).

tested on ASR1001, me3400, 2960, 2960X, 3020 - hp blade switch, 1941, 3560x, 3845, 4507

previous i.e.:
cisco340024TSA
cat29xxStack

now i.e.:
ME-3400-24TS-A
WS-C2960X-24TS-L

@crcro crcro fix for cisco hardware name detection
28bf6e6
@laf
Member
laf commented Dec 14, 2016

Got any examples of a before and after to see the difference?

@crcro
Contributor
crcro commented Dec 14, 2016

just posted

@scrutinizer-notifier

The inspection completed: 4 new issues

@laf
Member
laf commented Dec 14, 2016

All good with me. @librenms/reviewers?

@laf
laf approved these changes Dec 14, 2016 View changes
@murrant murrant merged commit de13f45 into librenms:master Dec 16, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@murrant
Contributor
murrant commented Dec 16, 2016

@crcro I just tested a little more and found one of my cisco devices with the hardware name at ENTITY-MIB::entPhysicalModelName.2001

@crcro crcro deleted the crcro:fix-cisco-hardware branch Jan 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment