New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move mib based polling into yaml config files #5234

Merged
merged 3 commits into from Jan 3, 2017

Conversation

Projects
None yet
4 participants
@laf
Member

laf commented Dec 24, 2016

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Moved mib polling calls into discover_device() function so they only need defining in the yaml definitions file now.

Updated docs to show new examples.

Updated html page to tell users they can enable per device + have per device check to show mib page.

Move code from includes/discovery/os/*.inc.php to includes/definitions/*.yaml.

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Dec 24, 2016

Auto-Deploy finished, Test PR at http://5234.ci.librenms.org or https://5234.ci.librenms.org

@laf laf changed the title from refactor: More mib based polling into yaml config files to refactor: Move mib based polling into yaml config files Dec 29, 2016

@laf

This comment has been minimized.

Member

laf commented Dec 29, 2016

bump

### Discovery
You need to add your desired MIBs to `/opt/librenms/mibs` folder. Afterwards you need to register your MIBs to the discovery function.
You need to add your desired MIBs to `/opt/librenms/mibs` folder. Afterwards you need to register your MIBs to the OS definition.

This comment has been minimized.

@murrant

murrant Jan 3, 2017

Member

This better?

You need to add your desired MIBs to `/opt/librenms/mibs` folder. 
You will then need to create a list of the OIDs you wish to use in the OS definition
@murrant

This comment has been minimized.

Member

murrant commented Jan 3, 2017

Other than the small documentation change +1

@laf

This comment has been minimized.

Member

laf commented Jan 3, 2017

Doc updated.

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Jan 3, 2017

Auto-Deploy finished, Test PR at http://5234.ci.librenms.org or https://5234.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Jan 3, 2017

The inspection completed: 658 Issues, 18 Patches

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Jan 3, 2017

Auto-Deploy finished, Test PR at http://5234.ci.librenms.org or https://5234.ci.librenms.org

@murrant murrant merged commit 7f5c555 into librenms:master Jan 3, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:mib-polling-move branch Jan 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment