newdevice: Added additional detection for Cisco WAP 321 #5172 #5248

Merged
merged 1 commit into from Dec 28, 2016

Projects

None yet

4 participants

@laf
Member
laf commented Dec 26, 2016

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Fixes: #5172

@laf laf newdevice: Added additional detection for Cisco WAP 321 #5172
a31158e
@laf laf added the New-Device label Dec 26, 2016
@scrutinizer-notifier

The inspection completed: 3 new issues, 3 updated code elements

@@ -3,3 +3,7 @@
if (str_contains($sysDescr, 'Cisco Small Business WAP')) {
$os = 'ciscowap';
}
+
@Rosiak
Rosiak Dec 28, 2016 Contributor

Very minor, but you could remove some code by just doing ||

@laf
laf Dec 28, 2016 Member

I've left it separate as it's sysDescr and sysObjectId. I'm not fussed either way just felt it was easier to read this way.

@Rosiak
Rosiak Dec 28, 2016 Contributor

¯_(ツ)_/¯

@Rosiak Rosiak merged commit 2fa4a0b into librenms:master Dec 28, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@laf laf deleted the laf:issue-5172 branch Dec 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment