New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update jpgraph source file to remove check for imageantialias() … #5284

Merged
merged 1 commit into from Jan 2, 2017

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented Jan 2, 2017

#5282

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Fixes: #5282

I've edited the source code directly for jpgraph here, basically implementing a change they have done themselves but in a version which drops support for php 5.3. HuasoFoundries/jpgraph@d7c76bc

@murrant - You ok with this? We won't be updating jpgraph until we drop php 5.3 support anyway at which point we can update and this fix will then be implemented anyway.

@laf laf added the Bug 🐞 label Jan 2, 2017

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Jan 2, 2017

Auto-Deploy finished, Test PR at http://5284.ci.librenms.org or https://5284.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Jan 2, 2017

The inspection completed: No new issues

@murrant

This comment has been minimized.

Member

murrant commented Jan 2, 2017

Our Jpgraph is custom at this point anyway, until we don't support PHP 5.3...

@murrant

murrant approved these changes Jan 2, 2017

@Rosiak Rosiak merged commit 442b3ee into librenms:master Jan 2, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:issue-5282 branch Jan 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment