Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Moved simple os discovery into yaml config #5313

Merged
merged 1 commit into from Jan 6, 2017

Conversation

Projects
None yet
3 participants
@laf
Copy link
Member

commented Jan 4, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

This moves, where possible, all OS discovery into the yaml config files to simplify the code base.

@LibreNMS-CI

This comment has been minimized.

Copy link

commented Jan 4, 2017

Auto-Deploy finished, Test PR at http://5313.ci.librenms.org or https://5313.ci.librenms.org

@murrant

This comment has been minimized.

Copy link
Member

commented Jan 6, 2017

Looks great, thanks @laf.

@murrant murrant merged commit 81024f0 into librenms:master Jan 6, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:move-disco-yaml branch Jan 6, 2017

@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.