New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Centos 7 nginx install steps #5316

Merged
merged 2 commits into from Jan 6, 2017

Conversation

Projects
None yet
5 participants
@matthewaaronthacker
Contributor

matthewaaronthacker commented Jan 5, 2017

Found some issues on a fresh install of Centos 7. PHP defaults to listening on a port, while LibreNMS expects a unix socket. Also, the listen owner has to match the account that nginx runs under.
This is my first proposed change on Github so if I'm doing this all wrong, feel free to smack me down.
Thanks.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Update Centos 7 nginx install steps
Found some issues on a fresh install of Centos 7. PHP defaults to listening on a port, while LibreNMS expects a unix socket. Also, the listen owner has to match the account that nginx runs under.
This is my first proposed change on Github so if I'm doing this all wrong, feel free to smack me down.
Thanks.
@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Jan 5, 2017

Auto-Deploy finished, Test PR at http://5316.ci.librenms.org or https://5316.ci.librenms.org

@laf

This comment has been minimized.

Member

laf commented Jan 5, 2017

Thanks for this, we try and keep the docs standard so we can maintain them across all variations. If you can either remove the two new headers you've added #### or add the same to the other three main install docs, Centos7 Apache, Ubuntu 16.04 Apache / Nginx then we can merge this.

Removed the added headers
To keep things standard between all the different variations.
@matthewaaronthacker

This comment has been minimized.

Contributor

matthewaaronthacker commented Jan 5, 2017

Done! Does that work better having "Restart PHP" as normal text rather than a heading, or should I just remove that text entirely?

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Jan 5, 2017

Auto-Deploy finished, Test PR at http://5316.ci.librenms.org or https://5316.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Jan 5, 2017

The inspection completed: No new issues

@murrant

murrant approved these changes Jan 6, 2017

@laf laf merged commit 76516e8 into librenms:master Jan 6, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment