Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Oxidized basic config search #5333

Merged
merged 3 commits into from Jan 9, 2017

Conversation

Projects
None yet
5 participants
@Rosiak
Copy link
Member

commented Jan 6, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Hacked this together this eve.

Depending on the progress of ytti/oxidized-web#111

This enables you to leverage the Oxidized's API Config search function, giving you the ability to search through configs stored in Oxidized. Example could be that you want to find all the Cisco devices with "no service password-encryption" command set.

This is VERY basic, code should be refactored and prettified some.
Output should also be better as it only yields matches for now.
Feel free to take it from here, at least this is a start.

screen shot 2017-01-07 at 00 10 04

@Rosiak Rosiak changed the title Oxidized basic config search feature: Oxidized basic config search Jan 6, 2017

@LibreNMS-CI

This comment has been minimized.

Copy link

commented Jan 6, 2017

Auto-Deploy finished, Test PR at http://5333.ci.librenms.org or https://5333.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Copy link

commented Jan 8, 2017

Auto-Deploy finished, Test PR at http://5333.ci.librenms.org or https://5333.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Copy link

commented Jan 8, 2017

The inspection completed: 1 updated code elements

@laf

This comment has been minimized.

Copy link
Member

commented Jan 8, 2017

@Rosiak can you give this small update a test, it's just to use the helper functions to clean and display code.

@Rosiak

This comment has been minimized.

Copy link
Member Author

commented Jan 9, 2017

@laf Works fine, thanks!

@laf laf merged commit 92aab16 into librenms:master Jan 9, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@DonovanEsterhuizen

This comment has been minimized.

Copy link

commented Jan 10, 2017

Where in th ui can I find this?

@DonovanEsterhuizen

This comment has been minimized.

Copy link

commented Jan 12, 2017

Has this been released yet?

@laf

This comment has been minimized.

Copy link
Member

commented Jan 13, 2017

It's already live in the dev / daily branch but relies on an update from oxidized which afaik isn't yet released.

@Rosiak Rosiak deleted the Rosiak:oxidized-basic-config-search branch Feb 5, 2017

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.