Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: Disabled editing device notes for non-admin users #5341

Merged
merged 1 commit into from Jan 8, 2017

Conversation

Projects
None yet
4 participants
@laf
Copy link
Member

laf commented Jan 8, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

I realise that some people might say they needed this as it's been in for so long but the whole point of global read only is not to be able to edit things.

Fixes: #5323

@laf laf added the WebUI label Jan 8, 2017

@LibreNMS-CI

This comment has been minimized.

Copy link

LibreNMS-CI commented Jan 8, 2017

Auto-Deploy finished, Test PR at http://5341.ci.librenms.org or https://5341.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Copy link

scrutinizer-notifier commented Jan 8, 2017

The inspection completed: No new issues

@Rosiak Rosiak merged commit 36e1cc8 into librenms:master Jan 8, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:edit-device-notes branch Jan 8, 2017

@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.