New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't support unifi clients that don't report data #5383

Merged
merged 1 commit into from Jan 10, 2017

Conversation

Projects
None yet
5 participants
@murrant
Member

murrant commented Jan 10, 2017

better messages from the poller (for unifi at least)
Some cleanups in wifi.inc.php

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Addresses: #5271

fix: don't support unifi clients that don't report data
better messages from the poller (for unifi at least)
Some cleanups in wifi.inc.php
@mention-bot

This comment has been minimized.

mention-bot commented Jan 10, 2017

Thank you for submitting a PR @murrant! We have found the following @jquagga, @guillemmateos and @barryodonovan based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Jan 10, 2017

Auto-Deploy finished, Test PR at http://5383.ci.librenms.org or https://5383.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Jan 10, 2017

The inspection completed: No new issues

@ghost

This comment has been minimized.

ghost commented Jan 10, 2017

I like this. Much prettier than what I glued together! :).

I tested this on my UAPs and they work just as before. I don't have any Gen1's to test the "not supported" functionality though.

One thing to put out there on the radar is that the newest UAPs (for example the UAP-AC-HD which is beta) have 3 radios instead of the two. They do 2.4, 5Ghz and have a separate management radio. I don't own one so I'm not sure how that's going to show up in snmp. If it's separate I believe the existing code would consider clients connected to the management radio as being part of "na" since they aren't "ng". Again, that's speculation as I don't have the device to test.

@murrant

This comment has been minimized.

Member

murrant commented Jan 10, 2017

The OIDs used for this count the number of clients per SSID and group them based on frequency class (ng or ac).

So, I expect this will continue to function fine with the new radios.

@laf laf merged commit 1e131c9 into librenms:master Jan 10, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@murrant murrant deleted the murrant:wifi-cleanup branch Jan 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment