New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Added Tomato and AsusWRT-Merlin OS #5254 #5398

Merged
merged 2 commits into from Jan 13, 2017

Conversation

Projects
None yet
4 participants
@laf
Member

laf commented Jan 11, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Fixes: #5254

These work with distro script as well but as it's possible to detect I've done just that

@mention-bot

This comment has been minimized.

mention-bot commented Jan 11, 2017

Thank you for submitting a PR @laf! We have found the following @crcro, @murrant and @Rosiak based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Jan 11, 2017

Auto-Deploy finished, Test PR at http://5398.ci.librenms.org or https://5398.ci.librenms.org

@murrant

This comment has been minimized.

Member

murrant commented Jan 11, 2017

I know how to move the discovery to yaml, but it requires another change first... Move yaml discovery before the os includes.

@murrant murrant merged commit 89a2847 into librenms:master Jan 13, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:issue-5254 branch Jan 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment