fix: Updated prestige detection #5453 #5470

merged 1 commit into from Jan 17, 2017


None yet

5 participants

laf commented Jan 16, 2017


Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Fixes: #5453

Fixes the prestige detection (the ^ was dropped at some point :( ) and adds another test for VRP which detected this issue.


Thank you for submitting a PR @laf! We have found the following @murrant, @Rosiak and @barryodonovan based on the history of these files to review this PR.


The inspection completed: No new issues

@laf laf fix: Updated prestiage detection #5453
@laf laf changed the title from fix: Updated prestiage detection #5453 to fix: Updated prestige detection #5453 Jan 16, 2017
@murrant murrant merged commit 83ab72b into librenms:master Jan 17, 2017

2 checks passed

Auto-Deploy Build finished.
continuous-integration/travis-ci/pr The Travis CI build passed
@laf laf deleted the laf:issue-5453 branch Jan 17, 2017
@laf laf added a commit to InsaneSplash/librenms that referenced this pull request Jan 21, 2017
@InsaneSplash @laf InsaneSplash + laf # This is a combination of 17 commits.
# The first commit's message is:
I agree to the conditions of the Contributor Agreement contained in doc/General/

# This is the 2nd commit message:

Fixed error in files

# This is the 3rd commit message:

Change the colour of the port icon

# This is the 4th commit message:

Revert "Fixed error in files"

This reverts commit f64cb07.

# This is the 5th commit message:

Fixed error in files

# This is the 6th commit message:

Revised the primary menu to try standardise icons and layout. Fixed icon size for countdown_timer icons.

# This is the 7th commit message:

Fixed formatting non-compliance testing

# This is the 8th commit message:

Updated additional icons and adjusted to meet the new standard as per menu bar

# This is the 9th commit message:

found a few more lurkers

# This is the 10th commit message:

webui: Update add/edit user page to use their instead of his #5457 (#5460)

# This is the 11th commit message:

newdevice: Add wifi clients for Deliberant DLB APC Button, DLB APC Button AF and DLB APC 2mi #5456

# This is the 12th commit message:

various small doc improvements (#5459)

# This is the 13th commit message:

newdevice: Added CPU support for Edge Core OS

# This is the 14th commit message:

newdevice: Added support for CTC Union devices (#5402)

* newdevice: Added support for CTC Union devices

* added logo

* added unit test

* added missing snmprec file

* replaced logo

* reverted logo

* and again :/

# This is the 15th commit message:

fix: validate suid is set for fping (#5474)

# This is the 16th commit message:

fix as reported by @Compizfox (#5473)

# This is the 17th commit message:

fix: Updated prestiage detection #5453 (#5470)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment