webui: Update Font Awesome to 4.7.0 #5476

Merged
merged 2 commits into from Jan 18, 2017

Projects

None yet

6 participants

@Rosiak
Contributor
Rosiak commented Jan 16, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?
@Rosiak Rosiak webui: Update Font Awesome
c9dcc69
@murrant murrant changed the title from webui: Update Font Awesome to webui: Update Font Awesome to 4.7.0 Jan 16, 2017
@laf
Member
laf commented Jan 16, 2017

Are we duplicating files here? Before FA was loaded into lib/ which seems to the case still but all the symlinks from html/* back to lib/fa/* are now replaced with the full files as well.

@InsaneSplash
Contributor
InsaneSplash commented Jan 17, 2017 edited

Don't we rather just need the 2 CSS files to provide the fa icons, or do you require the whole package to be part of the repo?

@Rosiak
Contributor
Rosiak commented Jan 17, 2017

We briefly had a discussion on IRC regarding this earlier today.
Should we remove the lib completely and just keep the necessary files?

@InsaneSplash
Contributor

I'd say why include stuff that's not required...it would de-bloat the installation and reduce its size a little if the whole package wasn't included. Also make for easier updating in the future.

@laf
Member
laf commented Jan 17, 2017

Remove.

@Rosiak Rosiak remove lib
58dc83d
@scrutinizer-notifier

The inspection completed: 660 Issues, 18 Patches

@murrant

Tested, looks good.

@murrant murrant merged commit 61b73e8 into librenms:master Jan 18, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fenice2 fenice2 referenced this pull request Jan 19, 2017
Closed

Problem with non-standard mysql port #5514

0 of 5 tasks complete
@Rosiak Rosiak deleted the Rosiak:fa-update branch Feb 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment