New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert set_numeric use #5480

Merged
merged 2 commits into from Jan 17, 2017

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented Jan 16, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Fixes: #5477
@Rosiak

@mention-bot

This comment has been minimized.

mention-bot commented Jan 16, 2017

Thank you for submitting a PR @laf! We have found the following @HenocKA, @murrant and @geordish based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Jan 16, 2017

Auto-Deploy finished, Test PR at http://5480.ci.librenms.org or https://5480.ci.librenms.org

@@ -222,7 +222,7 @@
foreach ($ospf_ports_poll as $ospf_port_id => $ospf_port) {
// If the entry doesn't already exist in the prebuilt array, insert into the database and put into the array
if (empty($ospf_ports_db[$ospf_port_id][$device['context_name']])) {
dbInsert(array('device_id' => $device['device_id'], 'ospf_port_id' => $ospf_port_id, 'context_name' => $device['context_name']), 'ospf_ports');
bInsert(array('device_id' => $device['device_id'], 'ospf_port_id' => $ospf_port_id, 'context_name' => $device['context_name']), 'ospf_ports');

This comment has been minimized.

@murrant

murrant Jan 16, 2017

Member

Is this intended?

This comment has been minimized.

@laf

laf Jan 17, 2017

Member

Of course not.

fix
@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Jan 17, 2017

Auto-Deploy finished, Test PR at http://5480.ci.librenms.org or https://5480.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Jan 17, 2017

The inspection completed: 2 new issues

@murrant murrant merged commit e736dca into librenms:master Jan 17, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:issue-5477 branch Jan 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment