revert set_numeric use #5480

Merged
merged 2 commits into from Jan 17, 2017

Projects

None yet

5 participants

@laf
Member
laf commented Jan 16, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Fixes: #5477
@Rosiak

@laf laf revert set_numeric use
715bb68
@mention-bot

Thank you for submitting a PR @laf! We have found the following @HenocKA, @murrant and @geordish based on the history of these files to review this PR.

includes/polling/ospf.inc.php
@@ -222,7 +222,7 @@
foreach ($ospf_ports_poll as $ospf_port_id => $ospf_port) {
// If the entry doesn't already exist in the prebuilt array, insert into the database and put into the array
if (empty($ospf_ports_db[$ospf_port_id][$device['context_name']])) {
- dbInsert(array('device_id' => $device['device_id'], 'ospf_port_id' => $ospf_port_id, 'context_name' => $device['context_name']), 'ospf_ports');
+ bInsert(array('device_id' => $device['device_id'], 'ospf_port_id' => $ospf_port_id, 'context_name' => $device['context_name']), 'ospf_ports');
@murrant
murrant Jan 16, 2017 Contributor

Is this intended?

@laf
laf Jan 17, 2017 Member

Of course not.

@laf laf fix
a464a33
@scrutinizer-notifier

The inspection completed: 2 new issues

@murrant murrant merged commit e736dca into librenms:master Jan 17, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@laf laf deleted the laf:issue-5477 branch Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment