New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify dell-laser.yaml for B5460dn and B3460dn support #5482

Merged
merged 4 commits into from Jan 19, 2017

Conversation

Projects
None yet
6 participants
@wackychocolatefactory
Contributor

wackychocolatefactory commented Jan 17, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?
@mention-bot

This comment has been minimized.

mention-bot commented Jan 17, 2017

Thank you for submitting a PR @wackychocolatefactory! We have found the following @murrant and @laf based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Jan 17, 2017

Auto-Deploy finished, Test PR at http://5482.ci.librenms.org or https://5482.ci.librenms.org

@laf

This comment has been minimized.

Member

laf commented Jan 17, 2017

Same again with this one :)

jacobmulquin added some commits Jan 18, 2017

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Jan 18, 2017

Auto-Deploy finished, Test PR at http://5482.ci.librenms.org or https://5482.ci.librenms.org

1 similar comment
@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Jan 18, 2017

Auto-Deploy finished, Test PR at http://5482.ci.librenms.org or https://5482.ci.librenms.org

@laf

This comment has been minimized.

Member

laf commented Jan 18, 2017

The unit tests need to be in there own file :)

Paste here what the full output is of sysDescr and sysObjectId and I'll show you an example.

@wackychocolatefactory

This comment has been minimized.

Contributor

wackychocolatefactory commented Jan 18, 2017

Ah my mistake!

sysDescr.0 = Dell B3460dn Laser Printer version NH5.CY.N543 kernel 3.0.0 All-N-1

sysObjectID.0 = enterprises.674.108*.51.1094473269

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Jan 19, 2017

Auto-Deploy finished, Test PR at http://5482.ci.librenms.org or https://5482.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Jan 19, 2017

The inspection completed: 663 Issues, 18 Patches

@laf laf merged commit ae0898e into librenms:master Jan 19, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment