Modify dell-laser.yaml for B5460dn and B3460dn support #5482

Merged
merged 4 commits into from Jan 19, 2017

Projects

None yet

5 participants

@jacobau
Contributor
jacobau commented Jan 17, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?
@jacobau jacobau Modify for B5460dn and B3460dn support
c85b783
@mention-bot

Thank you for submitting a PR @wackychocolatefactory! We have found the following @murrant and @laf based on the history of these files to review this PR.

@laf
Member
laf commented Jan 17, 2017

Same again with this one :)

jacobau added some commits Jan 18, 2017
@jacobau jacobau Update dell-laser.snmprec
8dc1cff
@jacobau jacobau Update dell-laser.yaml
4c9e510
@laf
Member
laf commented Jan 18, 2017

The unit tests need to be in there own file :)

Paste here what the full output is of sysDescr and sysObjectId and I'll show you an example.

@jacobau
Contributor
jacobau commented Jan 18, 2017

Ah my mistake!

sysDescr.0 = Dell B3460dn Laser Printer version NH5.CY.N543 kernel 3.0.0 All-N-1

sysObjectID.0 = enterprises.674.108*.51.1094473269

@laf laf update unit test
c002fec
@scrutinizer-notifier

The inspection completed: 663 Issues, 18 Patches

@laf laf merged commit ae0898e into librenms:master Jan 19, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment