Modify xerox.yaml for DocuPrint M225 #5484

Merged
merged 2 commits into from Jan 19, 2017

Projects

None yet

6 participants

@jacobau
Contributor
jacobau commented Jan 17, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?
@jacobau jacobau Modify for Xerox DocuPrint M225
645de61
@mention-bot

Thank you for submitting a PR @wackychocolatefactory! We have found the following @laf based on the history of these files to review this PR.

@jacobau jacobau changed the title from Modify for Xerox DocuPrint M225 to Modify xerox.yaml for DocuPrint M225 Jan 17, 2017
@jacobau
Contributor
jacobau commented Jan 17, 2017

Sure thing, I'll write them up tomorrow at work. :)

@jacobau
Contributor
jacobau commented Jan 18, 2017

Curious, does this one need a new unit test, wouldn't the existing unit test cover the new regex?

@laf
Member
laf commented Jan 18, 2017

It possibly will but it's more the real world data we want. If detection was changed in the future we would only be able to ensure it matches what we have now and could break things.

includes/definitions/xerox.yaml
@@ -10,3 +10,4 @@ discovery:
- Xerox Phaser
- Xerox WorkCentre
- FUJI XEROX DocuPrint
+ - sysDescr_regex: '/^.*DocuPrint.*/'
@murrant
murrant Jan 18, 2017 Contributor

This is actually the same as - sysDescr: DocuPrint the sysDescr section searches for the given string anywhere in the sysDescr

@laf laf updated xerox detection
ec4b99d
@scrutinizer-notifier

The inspection completed: 663 Issues, 18 Patches

@laf laf merged commit 81bde0b into librenms:master Jan 19, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment