New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify xerox.yaml for DocuPrint M225 #5484

Merged
merged 2 commits into from Jan 19, 2017

Conversation

Projects
None yet
7 participants
@wackychocolatefactory
Contributor

wackychocolatefactory commented Jan 17, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?
@mention-bot

This comment has been minimized.

mention-bot commented Jan 17, 2017

Thank you for submitting a PR @wackychocolatefactory! We have found the following @laf based on the history of these files to review this PR.

@wackychocolatefactory wackychocolatefactory changed the title from Modify for Xerox DocuPrint M225 to Modify xerox.yaml for DocuPrint M225 Jan 17, 2017

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Jan 17, 2017

Auto-Deploy finished, Test PR at http://5484.ci.librenms.org or https://5484.ci.librenms.org

@laf

This comment has been minimized.

@wackychocolatefactory

This comment has been minimized.

Contributor

wackychocolatefactory commented Jan 17, 2017

Sure thing, I'll write them up tomorrow at work. :)

@wackychocolatefactory

This comment has been minimized.

Contributor

wackychocolatefactory commented Jan 18, 2017

Curious, does this one need a new unit test, wouldn't the existing unit test cover the new regex?

@laf

This comment has been minimized.

Member

laf commented Jan 18, 2017

It possibly will but it's more the real world data we want. If detection was changed in the future we would only be able to ensure it matches what we have now and could break things.

@@ -10,3 +10,4 @@ discovery:
- Xerox Phaser
- Xerox WorkCentre
- FUJI XEROX DocuPrint
- sysDescr_regex: '/^.*DocuPrint.*/'

This comment has been minimized.

@murrant

murrant Jan 18, 2017

Member

This is actually the same as - sysDescr: DocuPrint the sysDescr section searches for the given string anywhere in the sysDescr

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Jan 19, 2017

Auto-Deploy finished, Test PR at http://5484.ci.librenms.org or https://5484.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Jan 19, 2017

The inspection completed: 663 Issues, 18 Patches

@laf laf merged commit 81bde0b into librenms:master Jan 19, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment