New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ifAlias #5546

Merged
merged 1 commit into from Jan 27, 2017

Conversation

Projects
None yet
5 participants
@patrick7
Contributor

patrick7 commented Jan 21, 2017

Make script working for GRE-Interfaces

29: vpn-gre2@NONE: <POINTOPOINT,NOARP,UP,LOWER_UP> mtu 1400 qdisc noqueue state UNKNOWN mode DEFAULT group default
link/gre abc peer def

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?
Update ifAlias
Make script working for GRE-Interfaces

29: vpn-gre2@NONE: <POINTOPOINT,NOARP,UP,LOWER_UP> mtu 1400 qdisc noqueue state UNKNOWN mode DEFAULT group default 
    link/gre abc peer def
@mention-bot

This comment has been minimized.

mention-bot commented Jan 21, 2017

Thank you for submitting a PR @patrickvelder! We have found the following @f0o based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Jan 21, 2017

Auto-Deploy finished, Test PR at http://5546.ci.librenms.org or https://5546.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Jan 21, 2017

The inspection completed: No new issues

@laf

This comment has been minimized.

Member

laf commented Jan 21, 2017

You mention in issue #5547 that the obs... script is working, have you taken this from there?

@patrick7

This comment has been minimized.

Contributor

patrick7 commented Jan 21, 2017

No. They use a perl script.
This update is about something different.

@laf

laf approved these changes Jan 23, 2017

@laf

This comment has been minimized.

Member

laf commented Jan 23, 2017

For me provides the same output as the existing script so no regression on CentOS7.

@librenms/reviewers

@laf laf merged commit 91dd6a2 into librenms:master Jan 27, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment