New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph for services would not work #5569

Merged
merged 3 commits into from Jan 25, 2017

Conversation

Projects
None yet
6 participants
@nerdalertdk
Contributor

nerdalertdk commented Jan 24, 2017

I agree to the conditions of the Contributor Agreement contained in doc/General/Contributing.md.

Just found an bug, when adding an new service is sets the server_ds to {} See here, end of line L46
And here we check if service is equal to {} and not empty

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • [x ] Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • [ x] Have you followed our code guidelines?
Graph for services would not work
I agree to the conditions of the Contributor Agreement contained in doc/General/Contributing.md.

Just found an bug, when adding an new service is sets the server_ds to {} [See here, end of line L46](https://github.com/librenms/librenms/blob/d5296319fbadd41dc5a82cbe4bbc6e3fa82b1cb7/includes/services.inc.php#L46)

And here we check if service is equal to {} and not empty
@mention-bot

This comment has been minimized.

mention-bot commented Jan 24, 2017

Thank you for submitting a PR @nerdalertdk! We have found the following @adaniels21487, @murrant and @infotek based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Jan 24, 2017

Auto-Deploy finished, Test PR at http://5569.ci.librenms.org or https://5569.ci.librenms.org

@murrant

This comment has been minimized.

Member

murrant commented Jan 24, 2017

Are you sure you don't need to check for both "" and "{}"?

@nerdalertdk

This comment has been minimized.

Contributor

nerdalertdk commented Jan 24, 2017

Don't but all new services get the {} on insert

@laf

This comment has been minimized.

Member

laf commented Jan 24, 2017

I have legacy services where service_ds is blank so yes, a check for both should be included.

nerdalertdk added some commits Jan 25, 2017

Update services.inc.php
check for {} and empty
@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Jan 25, 2017

Auto-Deploy finished, Test PR at http://5569.ci.librenms.org or https://5569.ci.librenms.org

1 similar comment
@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Jan 25, 2017

Auto-Deploy finished, Test PR at http://5569.ci.librenms.org or https://5569.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Jan 25, 2017

The inspection completed: No new issues

@nerdalertdk

This comment has been minimized.

Contributor

nerdalertdk commented Jan 25, 2017

Changed it but blanks should be working in the current version as long as the nagios service is returning graph data

@laf laf merged commit e53503c into librenms:master Jan 25, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment