Additional Font Awesome icons #5572

Merged
merged 3 commits into from Jan 25, 2017

Projects

None yet

6 participants

@InsaneSplash
Contributor

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?
@InsaneSplash InsaneSplash Additional Font Awesome icons
fc64ef5
@mention-bot

Thank you for submitting a PR @InsaneSplash! We have found the following @laf, @f0o and @murrant based on the history of these files to review this PR.

html/pages/settings/alerting.inc.php
@@ -362,7 +362,7 @@
<div class="panel-body">
<div class="form-group">
<div class="col-sm-2">
- <a href="https://connect.pagerduty.com/connect?vendor=2fc7c9f3c8030e74aae6&callback='.$callback.'"><img src="images/pd_connect_button.png" width="202" height="36" alt="Connect to PagerDuty"></a>
+ <a href="https://connect.pagerduty.com/connect?vendor=2fc7c9f3c8030e74aae6&callback='.$callback.'"><img src="https://pagerduty.com/assets/pd_connect_button.png width="202" height="36" alt="Connect to PagerDuty"></a>
@murrant
murrant Jan 24, 2017 Contributor

Hosts may not have internet connectivity. And while pagerduty won't work without connectivity, we don't want to show a broken image.

@InsaneSplash
Contributor
@InsaneSplash InsaneSplash Updated PagerDuty link logo
e0428a5
html/pages/apps.inc.php
if ($vars['app'] == $app['app_type']) {
echo "<span class='pagemenu-selected'>";
- // echo('<img src="images/icons/'.$app['app_type'].'.png" class="optionicon" />');
} else {
@laf
laf Jan 24, 2017 Member

Looks like you can get rid of this as well

@InsaneSplash InsaneSplash Removed unused else statement
b0514be
@scrutinizer-notifier

The inspection completed: No new issues

@laf laf merged commit 6a1fd3e into librenms:master Jan 25, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@InsaneSplash InsaneSplash deleted the InsaneSplash:update-fontawesome-2 branch Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment