Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Font Awesome icons #5572

Merged
merged 3 commits into from Jan 25, 2017

Conversation

Projects
None yet
6 participants
@InsaneSplash
Copy link
Contributor

InsaneSplash commented Jan 24, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?
@mention-bot

This comment has been minimized.

Copy link

mention-bot commented Jan 24, 2017

Thank you for submitting a PR @InsaneSplash! We have found the following @laf, @f0o and @murrant based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Copy link

LibreNMS-CI commented Jan 24, 2017

Auto-Deploy finished, Test PR at http://5572.ci.librenms.org or https://5572.ci.librenms.org

@@ -362,7 +362,7 @@
<div class="panel-body">
<div class="form-group">
<div class="col-sm-2">
<a href="https://connect.pagerduty.com/connect?vendor=2fc7c9f3c8030e74aae6&callback='.$callback.'"><img src="images/pd_connect_button.png" width="202" height="36" alt="Connect to PagerDuty"></a>
<a href="https://connect.pagerduty.com/connect?vendor=2fc7c9f3c8030e74aae6&callback='.$callback.'"><img src="https://pagerduty.com/assets/pd_connect_button.png width="202" height="36" alt="Connect to PagerDuty"></a>

This comment has been minimized.

Copy link
@murrant

murrant Jan 24, 2017

Member

Hosts may not have internet connectivity. And while pagerduty won't work without connectivity, we don't want to show a broken image.

@InsaneSplash

This comment has been minimized.

Copy link
Contributor Author

InsaneSplash commented Jan 24, 2017

@LibreNMS-CI

This comment has been minimized.

Copy link

LibreNMS-CI commented Jan 24, 2017

Auto-Deploy finished, Test PR at http://5572.ci.librenms.org or https://5572.ci.librenms.org

@InsaneSplash

This comment has been minimized.

Copy link
Contributor Author

InsaneSplash commented Jan 24, 2017

if ($vars['app'] == $app['app_type']) {
echo "<span class='pagemenu-selected'>";
// echo('<img src="images/icons/'.$app['app_type'].'.png" class="optionicon" />');
} else {

This comment has been minimized.

Copy link
@laf

laf Jan 24, 2017

Member

Looks like you can get rid of this as well

@LibreNMS-CI

This comment has been minimized.

Copy link

LibreNMS-CI commented Jan 25, 2017

Auto-Deploy finished, Test PR at http://5572.ci.librenms.org or https://5572.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Copy link

scrutinizer-notifier commented Jan 25, 2017

The inspection completed: No new issues

@laf laf merged commit 6a1fd3e into librenms:master Jan 25, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@InsaneSplash InsaneSplash deleted the InsaneSplash:update-fontawesome-2 branch Jan 26, 2017

@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.