New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: support large vendor logos #5573

Merged
merged 1 commit into from Jan 24, 2017

Conversation

Projects
None yet
4 participants
@murrant
Member

murrant commented Jan 24, 2017

These are often wider than icons, with a fallback to icons if the logo is not present
Logos are stored in /html/images/logos
SVG is preferred for HiDPI

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?
feature: support large vendor logos
These are often wider than icons, with a fallback to icons if the logo is not present
Logos are stored in /html/images/logos
SVG is preferred for HiDPI

@murrant murrant changed the title from feature: support large vendor logos to webui: support large vendor logos Jan 24, 2017

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Jan 24, 2017

The inspection completed: 5 updated code elements

@murrant

This comment has been minimized.

Member

murrant commented Jan 24, 2017

trigger ci

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Jan 24, 2017

Auto-Deploy finished, Test PR at http://5573.ci.librenms.org or https://5573.ci.librenms.org

@murrant murrant referenced this pull request Jan 24, 2017

Merged

Correcting some HP to HPE logo #5557

2 of 2 tasks complete

@laf laf merged commit da2c6c5 into librenms:master Jan 24, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@murrant murrant deleted the murrant:logos branch Jan 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment