fix: Fix broken netstats ip forward polling #5575

Merged
merged 2 commits into from Jan 24, 2017

Projects

None yet

6 participants

@Rosiak
Contributor
Rosiak commented Jan 24, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?
@Rosiak Rosiak fix: Fix broken netstats ip forward polling
1a00eb9
@mention-bot

Thank you for submitting a PR @Rosiak! We have found the following @murrant, @zarya and @laf based on the history of these files to review this PR.

- } else {
- $value = 'U';
- }
+ $rrd_def = array();
@murrant
murrant Jan 24, 2017 Contributor

For a single RRD def, you can just use

 $rrd_def = "DS:$oid:GAUGE:600:U:5000000";

Doesn't need to be an array.

@Rosiak Rosiak remove array
197e476
@scrutinizer-notifier

The inspection completed: No new issues

@laf laf merged commit f4b21ae into librenms:master Jan 24, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Rosiak Rosiak deleted the Rosiak:ip-forward-fix branch Feb 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment