fix: HTML Purifier would create tmp caches within the vendor folder, moved to users tmp dir #5561 #5596

Merged
merged 1 commit into from Jan 25, 2017

Projects

None yet

4 participants

@laf
Member
laf commented Jan 25, 2017 edited

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Fixes: #5561

HTMLPurifier will create a file in /opt/librenms/vendor/ezyang/htmlpurifier/library/HTMLPurifier/DefinitionCache/Serializer/HTML/ which is owned by your web server so a php composer update stops.

@laf laf fix: HTML Purifier would create tmp caches within the vendor folder, …
…moved to users tmp dir #5561
a60a754
@mention-bot

Thank you for submitting a PR @laf! We have found the following @murrant, @paulgear and @BarbarossaTM based on the history of these files to review this PR.

@murrant
Contributor
murrant commented Jan 25, 2017

Looks good.

We should probably only initialize one of these rather than doing it every time right?

@laf
Member
laf commented Jan 25, 2017

Probably makes more sense

@murrant murrant merged commit 599e1c4 into librenms:master Jan 25, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@laf laf deleted the laf:issue-5561 branch Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment