New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: HTML Purifier would create tmp caches within the vendor folder, moved to users tmp dir #5561 #5596

Merged
merged 1 commit into from Jan 25, 2017

Conversation

Projects
None yet
4 participants
@laf
Member

laf commented Jan 25, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Fixes: #5561

HTMLPurifier will create a file in /opt/librenms/vendor/ezyang/htmlpurifier/library/HTMLPurifier/DefinitionCache/Serializer/HTML/ which is owned by your web server so a php composer update stops.

@mention-bot

This comment has been minimized.

mention-bot commented Jan 25, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @paulgear and @BarbarossaTM based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Jan 25, 2017

Auto-Deploy finished, Test PR at http://5596.ci.librenms.org or https://5596.ci.librenms.org

@murrant

This comment has been minimized.

Member

murrant commented Jan 25, 2017

Looks good.

We should probably only initialize one of these rather than doing it every time right?

@laf

This comment has been minimized.

Member

laf commented Jan 25, 2017

Probably makes more sense

@murrant murrant merged commit 599e1c4 into librenms:master Jan 25, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:issue-5561 branch Jan 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment