New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Updated detection for Dasan NOS devices #5359 #5606

merged 2 commits into from Jan 25, 2017


None yet
5 participants

laf commented Jan 25, 2017


Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Fixes: #5359


This comment has been minimized.

mention-bot commented Jan 25, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @Rosiak and @crcro based on the history of these files to review this PR.


This comment has been minimized.

LibreNMS-CI commented Jan 25, 2017

Auto-Deploy finished, Test PR at or

@murrant murrant changed the title from Updated detection for Dasan NOS devices #5359 to newdevice: Updated detection for Dasan NOS devices #5359 Jan 25, 2017


This comment has been minimized.

scrutinizer-notifier commented Jan 25, 2017

The inspection completed: No new issues

@murrant murrant merged commit 61ec8e6 into librenms:master Jan 25, 2017

2 checks passed

Auto-Deploy Build finished.
continuous-integration/travis-ci/pr The Travis CI build passed

@laf laf deleted the laf:issue-5359 branch Jan 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment