Added support for Brocade 200E #5617

Merged
merged 16 commits into from Jan 27, 2017

Projects

None yet

4 participants

@aldemira
Contributor

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?
root and others added some commits Jan 25, 2017
root Changed hp icon to hpe icon ae88911
root Merge remote-tracking branch 'upstream/master' b763062
root Merge remote-tracking branch 'upstream/master' 523f125
root Moxa EtherDevice support 6597476
root Remove unnecessary commit (HPE logo for procurve devices)
ebde42a
root Merge remote-tracking branch 'upstream/master'
a94453f
root Made changes according to the code review process
8036f2c
@aldemira aldemira Fixed formatting errors detected by travis
d81d00c
@aldemira aldemira Also changed the type from switch to network
156899b
@aldemira aldemira comply with mib dir change
60ea653
root Merge remote-tracking branch 'upstream/master' 7ccb41e
root Added support for Brocade 200E
c4a5e8a
@aldemira aldemira changed the title from Add support for Brocade 200E to Added support for Brocade 200E Jan 26, 2017
@laf
Member
laf commented Jan 26, 2017

You need to also add the extra test call into tests/OSDiscoveryTest.php

@laf
Member
laf commented Jan 26, 2017

Also, whilst you are at it, can you change your github name in AUTHORS.md to aldemira rather than aldemir_a.

It's also worth to mention that you should avoid working in your master branch. We have docs to help you with that :)

aldemira added some commits Jan 26, 2017
@aldemira aldemira Added missing discovery test
afb79ca
@aldemira aldemira Changed my username to the correct one
8dbf536
@laf
Member
laf commented Jan 26, 2017

Sorry my head isn't with it :(

Can you add sysDescr to the test unit file, it's not used for discovery but helps with the whole unit testing piece in general.

@aldemira
Contributor

I would, but sysDescr string says "Fibre Channel Switch."
I think it's a bit too generic, don't you think so?

@laf
Member
laf commented Jan 26, 2017

Not really, yes it is generic but if someone adds a new device which only matches on Fibre Channel sysDescr and it runs before this one then it will break detection. The more test data we have the better :)

aldemira added some commits Jan 27, 2017
@aldemira aldemira Merge remote-tracking branch 'upstream/master' d4fc128
@aldemira aldemira Added sysDescr to 200E tests
fe83f52
@scrutinizer-notifier

The inspection completed: No new issues

@laf laf merged commit 46003a3 into librenms:master Jan 27, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment