New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Basic Draytek Support #5625

Merged
merged 1 commit into from Jan 26, 2017

Conversation

Projects
None yet
4 participants
@InsaneSplash
Contributor

InsaneSplash commented Jan 26, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • [x ] Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?
@mention-bot

This comment has been minimized.

mention-bot commented Jan 26, 2017

Thank you for submitting a PR @InsaneSplash! We have found the following @laf, @murrant and @Rosiak based on the history of these files to review this PR.

@@ -0,0 +1,2 @@
1.3.6.1.2.1.1.1.0|4|DrayTek Corporation

This comment has been minimized.

@murrant

murrant Jan 26, 2017

Member

Is this the actual sysDescr from the device?

This comment has been minimized.

@InsaneSplash

InsaneSplash Jan 26, 2017

Contributor

Yes,

.1.3.6.1.2.1.1.1.0 = STRING: DrayTek Corporation
.1.3.6.1.2.1.1.2.0 = OID: .1.3.6.1.4.1.7367
.1.3.6.1.2.1.1.3.0 = Timeticks: (63065182) 7 days, 7:10:51.82
.1.3.6.1.2.1.1.4.0 = STRING: info@draytek.com
.1.3.6.1.2.1.1.5.0 = STRING: ippbx

This comment has been minimized.

@murrant

murrant Jan 26, 2017

Member

Gotta love those descriptive descriptions :)

This comment has been minimized.

@InsaneSplash

InsaneSplash Jan 26, 2017

Contributor

Yeah!,

Why did the build fail though?

@laf laf merged commit 98ddc28 into librenms:master Jan 26, 2017

1 of 2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@InsaneSplash InsaneSplash deleted the InsaneSplash:draytek branch Feb 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment