New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logo scaling to support squarish logos #5647

merged 1 commit into from Jan 28, 2017


None yet
5 participants

murrant commented Jan 28, 2017

Also improve text alignment


Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?
fix: logo scalling to support squarish logos
Also improve text alignment

This comment has been minimized.

mention-bot commented Jan 28, 2017

Thank you for submitting a PR @murrant! We have found the following @benwa, @paulgear and @laf based on the history of these files to review this PR.


This comment has been minimized.

LibreNMS-CI commented Jan 28, 2017

Auto-Deploy finished, Test PR at or

@murrant murrant added the Bug 🐞 label Jan 28, 2017


This comment has been minimized.

scrutinizer-notifier commented Jan 28, 2017

The inspection completed: No new issues

@murrant murrant changed the title from fix: logo scalling to support squarish logos to fix: logo scaling to support squarish logos Jan 28, 2017

@laf laf merged commit 5d1d4cd into librenms:master Jan 28, 2017

2 checks passed

Auto-Deploy Build finished.
continuous-integration/travis-ci/pr The Travis CI build passed

@murrant murrant deleted the murrant:fix-logo-dimensions branch Feb 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment