newdevice: Added further support for Canon printers #5637 #5650

Merged
merged 3 commits into from Jan 28, 2017

Projects

None yet

4 participants

@laf
Member
laf commented Jan 28, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Switched to sysObjectId as we have no conflicts with this and may save just adding more sysDescr values. Partially fixes #5637

laf added some commits Jan 28, 2017
@laf laf newdevice: Added further support for Canon printers #5637 a01e7b0
@laf laf rebased
604b223
@laf laf added test file
942cbbf
@mention-bot

Thank you for submitting a PR @laf! We have found the following @murrant, @Rosiak and @crcro based on the history of these files to review this PR.

@scrutinizer-notifier

The inspection completed: No new issues

@laf laf merged commit f2e6cfb into librenms:master Jan 28, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@aldemira aldemira added a commit to aldemira/librenms that referenced this pull request Feb 9, 2017
@laf @aldemira laf + aldemira newdevice: Added further support for Canon printers #5637 (#5650) 0037583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment