New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore toners with values -2 which is unknown #5637 #5654

Merged
merged 1 commit into from Jan 31, 2017

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented Jan 28, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Fixes: #5637

The current level if this supply is a container;the remaining space if this supply is a receptacle. If this supply container/receptacle can reliably sense this value, the value is reported by the printer and is read-only;otherwise, the value may be written (by a Remote Control Panel or a Management Application). The value (-1) means other and specifically indicates that the sub-unit places no restrictions on this parameter. The value (-2) means unknown. A value of (-3) means that the printer knows that there is some supply/remaining space, respectively.

We ignore -2 now.

@mention-bot

This comment has been minimized.

mention-bot commented Jan 28, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @zarya and @tuxis-ie based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Jan 28, 2017

Auto-Deploy finished, Test PR at http://5654.ci.librenms.org or https://5654.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Jan 28, 2017

The inspection completed: No new issues

@laf laf referenced this pull request Jan 30, 2017

Closed

Canon printer models #5637

4 of 5 tasks complete

@laf laf merged commit 4390347 into librenms:master Jan 31, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:issue-5637-2 branch Jan 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment