webui: Only show sysName once if force_ip_to_sysname is enabled #5600 #5656

Merged
merged 2 commits into from Feb 1, 2017

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented Jan 29, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Fixes: #5600

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jan 29, 2017

Thank you for submitting a PR @laf! We have found the following @crcro, @murrant and @InsaneSplash based on the history of these files to review this PR.

Thank you for submitting a PR @laf! We have found the following @crcro, @murrant and @InsaneSplash based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@towster

This comment has been minimized.

Show comment
Hide comment
@towster

towster Jan 30, 2017

Contributor

instead of simply pulling the second sysName from the display could you make the second line display the IP?

Contributor

towster commented Jan 30, 2017

instead of simply pulling the second sysName from the display could you make the second line display the IP?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jan 30, 2017

Member

Updated.

Member

laf commented Jan 30, 2017

Updated.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jan 30, 2017

The inspection completed: No new issues

The inspection completed: No new issues

@laf laf merged commit 268d291 into librenms:master Feb 1, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:issue-5600 branch Feb 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment