New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add serial, model and version support for HPE MSL #5667

Merged
merged 2 commits into from Jan 30, 2017

Conversation

Projects
None yet
5 participants
@FTBZ
Contributor

FTBZ commented Jan 30, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

screen shot 2017-01-30 at 11 26 07

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jan 30, 2017

Thank you for submitting a PR @FTBZ! We have found the following @laf based on the history of these files to review this PR.

Thank you for submitting a PR @FTBZ! We have found the following @laf based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
Show outdated Hide outdated includes/polling/os/hpe-msl.inc.php
@@ -23,4 +23,8 @@
* @author Neil Lathwood <neil@lathwood.co.uk>
*/
$hardware = snmp_get($device, 'hpHttpMgDeviceProductCaption.0', '-OQUs');
$hardware_array = snmp_get_multi($device, 'hpHttpMgDeviceProductName.1 hpHttpMgDeviceSerialNumber.1 hpHttpMgDeviceVersion.1', '-OQUs', 'UPS-MIB');

This comment has been minimized.

@laf

laf Jan 30, 2017

Member

Should UPS-MIB not be SEMI-MIB?

@laf

laf Jan 30, 2017

Member

Should UPS-MIB not be SEMI-MIB?

@FTBZ

This comment has been minimized.

Show comment
Hide comment
@FTBZ

FTBZ Jan 30, 2017

Contributor

Copy/past issue after a git error. Sorry.

Contributor

FTBZ commented Jan 30, 2017

Copy/past issue after a git error. Sorry.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jan 30, 2017

The inspection completed: No new issues

The inspection completed: No new issues

@laf laf merged commit 01ab0dc into librenms:master Jan 30, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment