webui: Remove ifIndex from ports list and add debug button for data access #5679

Merged
merged 1 commit into from Feb 3, 2017

Conversation

Projects
None yet
6 participants
@laf
Member

laf commented Jan 30, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Removed the ifIndex as discussed here: https://community.librenms.org/t/benefit-of-listing-ifindex-number/467/3

The only way to get the ifIndex after that would be a db lookup so I've added a small tag icon which you can click to get more info.

image

@laf laf added the WebUI label Jan 30, 2017

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jan 30, 2017

Thank you for submitting a PR @laf! We have found the following @rkojedzinszky, @vizay and @murrant based on the history of these files to review this PR.

Thank you for submitting a PR @laf! We have found the following @rkojedzinszky, @vizay and @murrant based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jan 30, 2017

The inspection completed: 1 updated code elements

The inspection completed: 1 updated code elements

@adaniels21487

This comment has been minimized.

Show comment
Hide comment
@adaniels21487

adaniels21487 Feb 1, 2017

Contributor

Philosophical question:
Do we want to be displaying debugging output when debug is not enabled?

Contributor

adaniels21487 commented Feb 1, 2017

Philosophical question:
Do we want to be displaying debugging output when debug is not enabled?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 1, 2017

Member

It doesn't bother me either way. Easy enough to change it to do that.

By default it's not shown, you have to click the icon to get the info.

Member

laf commented Feb 1, 2017

It doesn't bother me either way. Easy enough to change it to do that.

By default it's not shown, you have to click the icon to get the info.

+{
+ if (is_array($data)) {
+ $data = htmlentities(json_encode($data));
+ return str_replace(',', ',<br />', $data);

This comment has been minimized.

@murrant

murrant Feb 3, 2017

Member

I think it would look cleaner without the , before the <br />, it doesn't need to be valid json.

@murrant

murrant Feb 3, 2017

Member

I think it would look cleaner without the , before the <br />, it doesn't need to be valid json.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 3, 2017

Member

trigger ci

Member

laf commented Feb 3, 2017

trigger ci

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

@murrant murrant merged commit bc72ab9 into librenms:master Feb 3, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:port-ifindex branch Feb 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment