New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rancid generator #5689

Merged
merged 5 commits into from Feb 2, 2017

Conversation

Projects
None yet
4 participants
@xbeaudouin
Contributor

xbeaudouin commented Jan 31, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

This simple code is a "simple" rancid configuration script generator. We may have to change the "rancid_map" array in other place, but until now this POC works.

Regards

Xavier Beaudouin added some commits Jan 31, 2017

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Jan 31, 2017

Auto-Deploy finished, Test PR at http://5689.ci.librenms.org or https://5689.ci.librenms.org

Xavier Beaudouin
@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Jan 31, 2017

Auto-Deploy finished, Test PR at http://5689.ci.librenms.org or https://5689.ci.librenms.org

Xavier Beaudouin
@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Jan 31, 2017

Auto-Deploy finished, Test PR at http://5689.ci.librenms.org or https://5689.ci.librenms.org

@laf

This comment has been minimized.

Member

laf commented Jan 31, 2017

Thanks for this.

I think we should at a minimum have a usage example in the script but ideally a docs page explaining how to use it.

@xbeaudouin

This comment has been minimized.

Contributor

xbeaudouin commented Jan 31, 2017

@laf would you like I make some documentation ? If so where ? :D

@laf

This comment has been minimized.

Member

laf commented Jan 31, 2017

Something like http://docs.librenms.org/Extensions/Smokeping/ but obviously called Rancid. In docs/extensions

Xavier Beaudouin
@xbeaudouin

This comment has been minimized.

Contributor

xbeaudouin commented Feb 2, 2017

Done, basic documentation :D

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Feb 2, 2017

Auto-Deploy finished, Test PR at http://5689.ci.librenms.org or https://5689.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Feb 2, 2017

The inspection completed: No new issues

@laf laf merged commit cb5dd29 into librenms:master Feb 2, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment