New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added myself to the contributors list and added the ability to list devices by location in the api #5693

Merged
merged 5 commits into from Feb 8, 2017

Conversation

Projects
None yet
5 participants
@gilrim
Contributor

gilrim commented Jan 31, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?
@mention-bot

This comment has been minimized.

mention-bot commented Jan 31, 2017

Thank you for submitting a PR @gilrim! We have found the following @laf, @murrant and @nerdalertdk based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Jan 31, 2017

Auto-Deploy finished, Test PR at http://5693.ci.librenms.org or https://5693.ci.librenms.org

@gilrim

This comment has been minimized.

Contributor

gilrim commented Jan 31, 2017

fixed code style

@gilrim gilrim closed this Jan 31, 2017

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Jan 31, 2017

Auto-Deploy finished, Test PR at http://5693.ci.librenms.org or https://5693.ci.librenms.org

@laf

This comment has been minimized.

Member

laf commented Jan 31, 2017

How come you closed this?

@gilrim

This comment has been minimized.

Contributor

gilrim commented Jan 31, 2017

lack of understanding of git - thought that would mean "I'm all done", not "forget this pr" :)

@gilrim gilrim reopened this Jan 31, 2017

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Jan 31, 2017

Auto-Deploy finished, Test PR at http://5693.ci.librenms.org or https://5693.ci.librenms.org

@laf

This comment has been minimized.

Member

laf commented Jan 31, 2017

All good - just needs docs :)

I've done a patch:

diff --git a/doc/API/API-Docs.md b/doc/API/API-Docs.md
index a332e3a..5419450 100644
--- a/doc/API/API-Docs.md
+++ b/doc/API/API-Docs.md
@@ -693,6 +693,7 @@ Input:
     - mac: search by mac address
     - ipv4: search by IPv4 address
     - ipv6: search by IPv6 address (compressed or uncompressed)
+    - location: search by location
   - query: If searching by, then this will be used as the input.
 Example:
 ```curl

@laf

This comment has been minimized.

Member

laf commented Feb 2, 2017

@gilrim this needs rebasing for AUTHORS.md

@laf

This comment has been minimized.

Member

laf commented Feb 7, 2017

@gilrim any further update on this?

gilrim added some commits Feb 8, 2017

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Feb 8, 2017

Auto-Deploy finished, Test PR at http://5693.ci.librenms.org or https://5693.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Feb 8, 2017

The inspection completed: 2 new issues

@laf laf merged commit 8b401fd into librenms:master Feb 8, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment