New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore ports where we only have two entries in the array, this signals bad data #1366 #5722

Merged
merged 3 commits into from Feb 3, 2017

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented Feb 2, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

It's a little bit of a hack but it works. Fixes #1366

laf added some commits Feb 1, 2017

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Feb 2, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @zarya and @tuxis-ie based on the history of these files to review this PR.

mention-bot commented Feb 2, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @zarya and @tuxis-ie based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Feb 2, 2017

Auto-Deploy finished, Test PR at http://5722.ci.librenms.org or https://5722.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Feb 2, 2017

Auto-Deploy finished, Test PR at http://5722.ci.librenms.org or https://5722.ci.librenms.org

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 2, 2017

Member

Updated this to ignore ports without ifDescr, ifAlias and ifName. Tested by @tobiasa1

Member

laf commented Feb 2, 2017

Updated this to ignore ports without ifDescr, ifAlias and ifName. Tested by @tobiasa1

@murrant

murrant approved these changes Feb 3, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Feb 3, 2017

Auto-Deploy finished, Test PR at http://5722.ci.librenms.org or https://5722.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Feb 3, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Feb 3, 2017

The inspection completed: No new issues

@laf laf merged commit 7dc5265 into librenms:master Feb 3, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:issue-1366 branch Feb 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment