New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support non-standard unix socket #5724

Merged
merged 7 commits into from Apr 6, 2017

Conversation

Projects
None yet
5 participants
@murrant
Member

murrant commented Feb 2, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Feb 2, 2017

Auto-Deploy finished, Test PR at http://5724.ci.librenms.org or https://5724.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Feb 2, 2017

Auto-Deploy finished, Test PR at http://5724.ci.librenms.org or https://5724.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Feb 3, 2017

Auto-Deploy finished, Test PR at http://5724.ci.librenms.org or https://5724.ci.librenms.org

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 3, 2017

Member

One issue with build-base which I'll push a change for.

What about *-wrapper.py scripts?

Member

laf commented Feb 3, 2017

One issue with build-base which I'll push a change for.

What about *-wrapper.py scripts?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 3, 2017

Member

Oh and html/install.php

Member

laf commented Feb 3, 2017

Oh and html/install.php

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 3, 2017

Member

Actually build-base.php needs updating to take config options from install.

Member

laf commented Feb 3, 2017

Actually build-base.php needs updating to take config options from install.

@murrant murrant added the Blocker 🚫 label Feb 6, 2017

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Feb 6, 2017

Member

Need to check the python scripts.
I'm not sure about build-base.php, I thought it was ok as it is in this PR, we do not pull in dbFacile.php in that file at this time.

Member

murrant commented Feb 6, 2017

Need to check the python scripts.
I'm not sure about build-base.php, I thought it was ok as it is in this PR, we do not pull in dbFacile.php in that file at this time.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 6, 2017

Member

I'll have to re-run it but it complains about needing an int not a string for the port.

Member

laf commented Feb 6, 2017

I'll have to re-run it but it complains about needing an int not a string for the port.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Feb 6, 2017

Member

OK, that's easy, I'll check it.

Member

murrant commented Feb 6, 2017

OK, that's easy, I'll check it.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Apr 5, 2017

Auto-Deploy finished, Test PR at http://5724.ci.librenms.org or https://5724.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Apr 5, 2017

Auto-Deploy finished, Test PR at http://5724.ci.librenms.org or https://5724.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Apr 5, 2017

Auto-Deploy finished, Test PR at http://5724.ci.librenms.org or https://5724.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Apr 5, 2017

Auto-Deploy finished, Test PR at http://5724.ci.librenms.org or https://5724.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Apr 5, 2017

Auto-Deploy finished, Test PR at http://5724.ci.librenms.org or https://5724.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Apr 5, 2017

Auto-Deploy finished, Test PR at http://5724.ci.librenms.org or https://5724.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Apr 5, 2017

Auto-Deploy finished, Test PR at http://5724.ci.librenms.org or https://5724.ci.librenms.org

Show outdated Hide outdated includes/dbFacile.php

murrant added some commits Apr 6, 2017

Refactor dbConnect
Use it everywhere
$config needs to be global
Don't need to set $database_link
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Apr 6, 2017

Auto-Deploy finished, Test PR at http://5724.ci.librenms.org or https://5724.ci.librenms.org

@murrant murrant removed the Blocker 🚫 label Apr 6, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Apr 6, 2017

Auto-Deploy finished, Test PR at http://5724.ci.librenms.org or https://5724.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 6, 2017

The inspection completed: 2 updated code elements

scrutinizer-notifier commented Apr 6, 2017

The inspection completed: 2 updated code elements

@murrant

@laf @f0o This should be ready to go. I tested build-base.php, install.php, irc.php, and validate.php.

@murrant murrant referenced this pull request Apr 6, 2017

Merged

Unit test to validate the db schema #6367

2 of 2 tasks complete

@laf laf merged commit b1a414e into librenms:master Apr 6, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

murrant added a commit to murrant/librenms that referenced this pull request Apr 7, 2017

feature: support non-standard unix socket (#5724)
* Add support for custom MySQL unix-socket

* NULL must be lowercase!

* Naive edit of html/install.php

* fixup

* Refactor dbConnect
Use it everywhere

* $config needs to be global
Don't need to set $database_link

* small cleanups

murrant added a commit to murrant/librenms that referenced this pull request Apr 7, 2017

feature: support non-standard unix socket (#5724)
* Add support for custom MySQL unix-socket

* NULL must be lowercase!

* Naive edit of html/install.php

* fixup

* Refactor dbConnect
Use it everywhere

* $config needs to be global
Don't need to set $database_link

* small cleanups

laf added a commit that referenced this pull request Apr 7, 2017

feature: Unit test to validate the db schema (#6367)
* Unit test to validate the db schema
Changes build-schema.php to just write misc/db_schema.yaml

* Only build base if needed
Fix 178.sql

* Database is always created by init.php
add dbSchema test too, should guard against testing against an empty database

* feature: support non-standard unix socket (#5724)

* Add support for custom MySQL unix-socket

* NULL must be lowercase!

* Naive edit of html/install.php

* fixup

* Refactor dbConnect
Use it everywhere

* $config needs to be global
Don't need to set $database_link

* small cleanups

* Connect to the database for every test.

* travis fix for blank line

@murrant murrant deleted the murrant:mysql-error branch Apr 18, 2017

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.