newdevice: Exterity AvediaPlayer support #5732

Merged
merged 2 commits into from Feb 2, 2017

Conversation

Projects
None yet
5 participants
@FTBZ
Contributor

FTBZ commented Feb 2, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

  • Add support for the Exterity AvediaPlayer units.

This a video converter to IP, we have no category for this kind of stuff... I used Appliance.

screen shot 2017-02-02 at 17 09 22

screen shot 2017-02-02 at 17 09 33

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 2, 2017

Member

Unit tests are failing at the moment.

Can you add sysObjectId output to the unit test file as well so it's more complete.

Member

laf commented Feb 2, 2017

Unit tests are failing at the moment.

Can you add sysObjectId output to the unit test file as well so it's more complete.

includes/definitions/avr-hd.yaml
+over:
+ - { graph: device_bits, text: Traffic }
+discovery:
+ - sysDescrId:

This comment has been minimized.

@laf

laf Feb 2, 2017

Member

We really should try and use sysObjectId for detection if possible. If not it's sysDescr anyway

@laf

laf Feb 2, 2017

Member

We really should try and use sysObjectId for detection if possible. If not it's sysDescr anyway

This comment has been minimized.

@FTBZ

FTBZ Feb 2, 2017

Contributor

SNMPwalk here:
http://pastebin.com/raw/Rem5nv9d

Don't think that's possible?

@FTBZ

FTBZ Feb 2, 2017

Contributor

SNMPwalk here:
http://pastebin.com/raw/Rem5nv9d

Don't think that's possible?

This comment has been minimized.

@murrant

murrant Feb 2, 2017

Member
discovery:
   - sysObectID:
        - .1.3.6.1.4.1.28194.
@murrant

murrant Feb 2, 2017

Member
discovery:
   - sysObectID:
        - .1.3.6.1.4.1.28194.

This comment has been minimized.

@FTBZ

FTBZ Feb 3, 2017

Contributor

Ok thx. During my test I used the latest digit, it was my error.

@FTBZ

FTBZ Feb 3, 2017

Contributor

Ok thx. During my test I used the latest digit, it was my error.

@FTBZ

This comment has been minimized.

Show comment
Hide comment
@FTBZ

FTBZ Feb 2, 2017

Contributor

Can you double check the code? I've noticed that all my devices are recognized as avr-hd and I don't know if it's since this PR or not (I've made some try after your message with the sysObjectId).

Contributor

FTBZ commented Feb 2, 2017

Can you double check the code? I've noticed that all my devices are recognized as avr-hd and I don't know if it's since this PR or not (I've made some try after your message with the sysObjectId).

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 2, 2017

Member

I've just pushed some small changes. Will merge once travis clears.

Member

laf commented Feb 2, 2017

I've just pushed some small changes. Will merge once travis clears.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Feb 2, 2017

The inspection completed: 1 updated code elements

The inspection completed: 1 updated code elements

@laf laf merged commit ab6f78d into librenms:master Feb 2, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment