New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Added the missing optional parameter to service checks #5753

Merged
merged 1 commit into from Feb 3, 2017

Conversation

Projects
None yet
4 participants
@InsaneSplash
Contributor

InsaneSplash commented Feb 3, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • [x ] Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • [x ] Have you followed our code guidelines?
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Feb 3, 2017

Thank you for submitting a PR @InsaneSplash! We have found the following @murrant and @adaniels21487 based on the history of these files to review this PR.

mention-bot commented Feb 3, 2017

Thank you for submitting a PR @InsaneSplash! We have found the following @murrant and @adaniels21487 based on the history of these files to review this PR.

@InsaneSplash InsaneSplash changed the title from added the service parameter to checks that were missing it to bug: Added the missing optional parameter to service checks Feb 3, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Feb 3, 2017

Auto-Deploy finished, Test PR at http://5753.ci.librenms.org or https://5753.ci.librenms.org

@laf laf merged commit bea8a14 into librenms:master Feb 3, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment