refactor: Various Code Cleanup #5777

Merged
merged 2 commits into from Feb 5, 2017

Conversation

Projects
None yet
5 participants
@Rosiak
Contributor

Rosiak commented Feb 5, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Feb 5, 2017

Thank you for submitting a PR @Rosiak! We have found the following @tuxis-ie, @murrant and @laf based on the history of these files to review this PR.

Thank you for submitting a PR @Rosiak! We have found the following @tuxis-ie, @murrant and @laf based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Feb 5, 2017

The inspection completed: 4 new issues, 1 updated code elements

The inspection completed: 4 new issues, 1 updated code elements

@laf laf merged commit 414efb3 into librenms:master Feb 5, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Rosiak Rosiak deleted the Rosiak:some-fixes branch Nov 15, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@librenms librenms locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.