New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Convert Hikvision discovery to yaml #5781

Merged
merged 1 commit into from Feb 6, 2017

Conversation

Projects
None yet
4 participants
@murrant
Member

murrant commented Feb 6, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?
@mention-bot

This comment has been minimized.

mention-bot commented Feb 6, 2017

Thank you for submitting a PR @murrant! We have found the following @laf, @Rosiak and @geordish based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Feb 6, 2017

Auto-Deploy finished, Test PR at http://5781.ci.librenms.org or https://5781.ci.librenms.org

@laf

This comment has been minimized.

Member

laf commented Feb 6, 2017

I'm pretty certain (at least with some older firmware for these) that sysObjectId isn't available.

I have the cameras at home (but now use an NVR so can't snmp directly to them) but in the original PR: https://github.com/librenms/librenms/pull/393/files you can see that I did a specific check that no sysObjectId existed and then did an additional snmp call.

@murrant

This comment has been minimized.

Member

murrant commented Feb 6, 2017

Ok, please update or close this if you can check them, thanks :)

@laf

This comment has been minimized.

Member

laf commented Feb 6, 2017

I can't :( It means removing them from my NVR and I'm that lazy right now :D

@murrant

This comment has been minimized.

Member

murrant commented Feb 6, 2017

haha, fair enough. I could possibly change it to support both.

@laf laf merged commit aef0928 into librenms:master Feb 6, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@laf

This comment has been minimized.

Member

laf commented Feb 6, 2017

Sod it, the units are awful enough on snmp so let's just hope it's fixed in newer firmware.

@murrant murrant deleted the murrant:hikvision branch Feb 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment