newdevice: Add Kyocera Mita support #5782

Merged
merged 21 commits into from Feb 6, 2017

Conversation

Projects
None yet
6 participants
@aldemira
Contributor

aldemira commented Feb 6, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Kyocera Mita printers have "KYOCERA MITA Printing System" in its sysDescr

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Feb 6, 2017

Thank you for submitting a PR @aldemira! We have found the following @laf based on the history of these files to review this PR.

Thank you for submitting a PR @aldemira! We have found the following @laf based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

@aldemira aldemira closed this Feb 6, 2017

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 6, 2017

Member

How come you closed this?

Member

laf commented Feb 6, 2017

How come you closed this?

@aldemira

This comment has been minimized.

Show comment
Hide comment
@aldemira

aldemira Feb 6, 2017

Contributor

I want to create a new branch, after rebasing my master branch to librenms/master. I don't like to see all those redundant commit messages here. I'll resubmit it soon.

Contributor

aldemira commented Feb 6, 2017

I want to create a new branch, after rebasing my master branch to librenms/master. I don't like to see all those redundant commit messages here. I'll resubmit it soon.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 6, 2017

Member

We squash and merge anyway so it really doesn't matter.

Member

laf commented Feb 6, 2017

We squash and merge anyway so it really doesn't matter.

@aldemira aldemira reopened this Feb 6, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@aldemira

This comment has been minimized.

Show comment
Hide comment
@aldemira

aldemira Feb 6, 2017

Contributor

Any idea why the test is failing?

Contributor

aldemira commented Feb 6, 2017

Any idea why the test is failing?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 6, 2017

Member

Just realised, you want to use sysDescr_regex rather than sysDescr in that yaml file.

Member

laf commented Feb 6, 2017

Just realised, you want to use sysDescr_regex rather than sysDescr in that yaml file.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 6, 2017

Member

I've pushed the fix, will merge once travis agrees.

Member

laf commented Feb 6, 2017

I've pushed the fix, will merge once travis agrees.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Feb 6, 2017

The inspection completed: No new issues

The inspection completed: No new issues

@laf laf merged commit d4ef6ba into librenms:master Feb 6, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@aldemira aldemira deleted the aldemira:kyocera branch Feb 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment