IP and Port API additions #5784

Merged
merged 7 commits into from Feb 7, 2017

Conversation

Projects
None yet
6 participants
@wrgeorge1983
Contributor

wrgeorge1983 commented Feb 6, 2017

  • /api/v0/devices/:hostname/ip: returns info for any IP addresses (4 or 6) on any interfaces on this device
  • /api/v0/ports: returns same info (and honors same columns parameter) as /api/v0/devices/:hostname/ports, but for all undeleted ports. Purpose is to avoid many recursive calls if you know you need all of them anyway.
  • /api/v0/ports/:portid: returns info for specific port, by port_id.
  • /api/v0/ports/:portid/ip: returns any ip addresses (4 or 6) on a specific port, by port_id

Also it looks like my editor played some whitespace shenanigans lower in the file? Not sure what happened there. If it's a problem I can dig in further.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Feb 6, 2017

Thank you for submitting a PR @wrgeorge1983! We have found the following @laf, @murrant and @nerdalertdk based on the history of these files to review this PR.

Thank you for submitting a PR @wrgeorge1983! We have found the following @laf, @murrant and @nerdalertdk based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 6, 2017

Member

All fine with me but you need to update the API docs.

Member

laf commented Feb 6, 2017

All fine with me but you need to update the API docs.

@laf

Needs API docs

Needs docs adding :)

laf and others added some commits Feb 7, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Feb 7, 2017

The inspection completed: 4 new issues, 3 updated code elements

The inspection completed: 4 new issues, 3 updated code elements

@laf laf removed the Blocker 🚫 label Feb 7, 2017

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 7, 2017

Member

All good, actually merged two functions into one for IP info.

Member

laf commented Feb 7, 2017

All good, actually merged two functions into one for IP info.

@laf laf merged commit 7240741 into librenms:master Feb 7, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 7, 2017

Member

image

Member

laf commented Feb 7, 2017

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment