New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error when host already exists rather than say it is due to snmp #5789

Merged
merged 1 commit into from Feb 6, 2017

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented Feb 6, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Shows the difference:

-bash-4.2$ ./addhost.php netbotz03 netbotz01 v2c 1161
Could not connect, please check the snmp details and snmp reachability
-bash-4.2$ ./addhost.php netbotz03 netbotz01 v2c 1161
Already have host netbotz03 (NETBOTZ01)
@mention-bot

This comment has been minimized.

mention-bot commented Feb 6, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @zarya and @Rosiak based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Feb 6, 2017

Auto-Deploy finished, Test PR at http://5789.ci.librenms.org or https://5789.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Feb 6, 2017

The inspection completed: No new issues

@murrant murrant merged commit aab1cda into librenms:master Feb 6, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:addhost-check branch Feb 6, 2017

laf added a commit that referenced this pull request Feb 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment