New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (very) simple Toshiba TEC (printer) support #5792

Merged
merged 4 commits into from Feb 6, 2017

Conversation

Projects
None yet
4 participants
@rockyluke
Contributor

rockyluke commented Feb 6, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

laf and others added some commits Feb 6, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
Show outdated Hide outdated includes/definitions/toshiba.yaml
@@ -0,0 +1,14 @@
os: toshiba

This comment has been minimized.

@laf

laf Feb 6, 2017

Member

I think we should change this to toshiba-printer, toshiba is too generic for a printer.

@laf

laf Feb 6, 2017

Member

I think we should change this to toshiba-printer, toshiba is too generic for a printer.

This comment has been minimized.

@rockyluke

rockyluke Feb 6, 2017

Contributor

Good idea. It's fixed.

@rockyluke

rockyluke Feb 6, 2017

Contributor

Good idea. It's fixed.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@rockyluke

This comment has been minimized.

Show comment
Hide comment
@rockyluke

rockyluke Feb 6, 2017

Contributor

I've switched from toshiba to toshiba-printer.

Contributor

rockyluke commented Feb 6, 2017

I've switched from toshiba to toshiba-printer.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 6, 2017

Member

I've put the logo back as toshiba can remain generic for future devices.

Member

laf commented Feb 6, 2017

I've put the logo back as toshiba can remain generic for future devices.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 6, 2017

Member

Actually toshiba-tec seemed more appropriate. I've updated and add unit tests.

Member

laf commented Feb 6, 2017

Actually toshiba-tec seemed more appropriate. I've updated and add unit tests.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Feb 6, 2017

The inspection completed: 1 updated code elements

The inspection completed: 1 updated code elements

@laf laf merged commit 6380176 into librenms:master Feb 6, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rockyluke rockyluke deleted the vp-noc:toshiba-tec branch Feb 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment