New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various variables will all be updated if they are blank #5811 #5836

Merged
merged 1 commit into from Feb 10, 2017

Conversation

Projects
None yet
4 participants
@laf
Member

laf commented Feb 8, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Fixes: #5811

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Feb 8, 2017

Thank you for submitting a PR @laf! We have found the following @crcro, @murrant and @paulgear based on the history of these files to review this PR.

mention-bot commented Feb 8, 2017

Thank you for submitting a PR @laf! We have found the following @crcro, @murrant and @paulgear based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Feb 8, 2017

Auto-Deploy finished, Test PR at http://5836.ci.librenms.org or https://5836.ci.librenms.org

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Feb 9, 2017

Member

My only concern is if one of these variables is null or something and the database returns ''. Causing it to b e updated every poll.

I'll try to test this, but my testing bandwidth has been pretty low of late :(

Member

murrant commented Feb 9, 2017

My only concern is if one of these variables is null or something and the database returns ''. Causing it to b e updated every poll.

I'll try to test this, but my testing bandwidth has been pretty low of late :(

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 9, 2017

Member
-bash-4.2$ cat /tmp/n.php
<?php

$t = null;
$s = '';

if ($t != $s) {
    echo 'notequals';
} else {
    echo 'equals';
}
-bash-4.2$ php /tmp/n.php
equals

Should be ok

Member

laf commented Feb 9, 2017

-bash-4.2$ cat /tmp/n.php
<?php

$t = null;
$s = '';

if ($t != $s) {
    echo 'notequals';
} else {
    echo 'equals';
}
-bash-4.2$ php /tmp/n.php
equals

Should be ok

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Feb 10, 2017

Member

Ah yes, you aren't using strict comparison.

Member

murrant commented Feb 10, 2017

Ah yes, you aren't using strict comparison.

@murrant murrant merged commit 2e235b2 into librenms:master Feb 10, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 10, 2017

Member

Yeah I only use strict when I know or trust the data

Member

laf commented Feb 10, 2017

Yeah I only use strict when I know or trust the data

@laf laf deleted the laf:issue-5811 branch Feb 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment