refactor: Centralise device up/down check and use in disco #5862 #5897

Merged
merged 4 commits into from Feb 15, 2017

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented Feb 14, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Fixes: #5862

Takes over #5870

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Feb 14, 2017

Thank you for submitting a PR @laf! We have found the following @HenocKA, @murrant and @tuxis-ie based on the history of these files to review this PR.

Thank you for submitting a PR @laf! We have found the following @HenocKA, @murrant and @tuxis-ie based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Feb 15, 2017

The inspection completed: 1 updated code elements

The inspection completed: 1 updated code elements

@laf laf merged commit 3816883 into librenms:master Feb 15, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:issue-5862-2 branch Feb 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment