New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated qnap sensor code to be more generic #5910 #5925

merged 3 commits into from Feb 17, 2017


None yet
4 participants

laf commented Feb 16, 2017


Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Tested in the issue and confirmed to be working. Also tested against a live qnap which didn't have the issue for me and I've maintained compatibility.

Fixes: #5910
Fixes: #5229


This comment has been minimized.

mention-bot commented Feb 16, 2017

Thank you for submitting a PR @laf! We have found the following @paulgear, @murrant and @adaniels21487 based on the history of these files to review this PR.


This comment has been minimized.

LibreNMS-CI commented Feb 16, 2017

Auto-Deploy finished, Test PR at or

1 similar comment

This comment has been minimized.

LibreNMS-CI commented Feb 17, 2017

Auto-Deploy finished, Test PR at or


This comment has been minimized.

scrutinizer-notifier commented Feb 17, 2017

The inspection completed: 1 updated code elements

@laf laf merged commit ced7591 into librenms:master Feb 17, 2017

2 checks passed

Auto-Deploy Build finished.
continuous-integration/travis-ci/pr The Travis CI build passed

@laf laf deleted the laf:issue-5910 branch Feb 17, 2017

@tuxi56 tuxi56 referenced this pull request Feb 19, 2017


QNAP snmp readings broken since #5925 #5946

5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment